nastra commented on PR #6626: URL: https://github.com/apache/iceberg/pull/6626#issuecomment-1398007171
> > not sure, usually it's been called out on my own PRs to adjust the error msg to that particular format (hence the reason I mentioned it on the other PR), which is being used across other places in Iceberg > > In that case, would it be better for us to change all the related null checks to checkArgument, and update the checkstyle rule for it to avoid use of checkNotNull? I think we could take this opportunity to set some standards. I think it's definitely worth discussing this so that people know what the accepted approach is and enforce it via checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
