amogh-jahagirdar commented on code in PR #5234:
URL: https://github.com/apache/iceberg/pull/5234#discussion_r1073952408
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -337,15 +340,20 @@ private CloseableIterable<ManifestEntry<DataFile>>
addedDataFiles(
TableMetadata base,
Long startingSnapshotId,
Expression dataFilter,
- PartitionSet partitionSet) {
+ PartitionSet partitionSet,
+ Snapshot parent) {
// if there is no current table state, no files have been added
- if (base.currentSnapshot() == null) {
+ if (parent == null) {
Review Comment:
My bad, missed this when I raised the change to your branch. I think we
should update this comment to say "If there is no parent, no files have been
added"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
