rdblue commented on code in PR #6609:
URL: https://github.com/apache/iceberg/pull/6609#discussion_r1072952176
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -372,6 +378,13 @@ public AuthSession(
this.credential = credential;
}
+ // this field is publicly visible/configurable for testing only. We can't
annotate it with
+ // @VisibleForTesting because we restrict via checkstyle that
@VisibleForTesting should be only
+ // applied to package-private things
+ public static void withTokenRefreshNumRetries(int retries) {
Review Comment:
Rather than making this public, can we add a public method in a test util
that sets it? That way we could make it package-private with a helper class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
