amogh-jahagirdar commented on PR #5234: URL: https://github.com/apache/iceberg/pull/5234#issuecomment-1384706303
Great work @namrathamyske, just some minor comments but at least the core of it around the tests looks good to me. When you get a chance to update the ReplacePartition tests that would be great, since we can then see all the CI tests pass (right now it looks to be failing since the ReplacePartition tests haven't been updated yet). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
