RussellSpitzer commented on code in PR #6588:
URL: https://github.com/apache/iceberg/pull/6588#discussion_r1070261893
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##########
@@ -231,24 +258,27 @@ protected DeleteSummary deleteFiles(
DeleteSummary summary = new DeleteSummary();
- Tasks.foreach(files)
- .retry(DELETE_NUM_RETRIES)
- .stopRetryOn(NotFoundException.class)
- .suppressFailureWhenFinished()
- .executeWith(executorService)
- .onFailure(
- (fileInfo, exc) -> {
- String path = fileInfo.getPath();
- String type = fileInfo.getType();
- LOG.warn("Delete failed for {}: {}", type, path, exc);
- })
- .run(
- fileInfo -> {
- String path = fileInfo.getPath();
- String type = fileInfo.getType();
- deleteFunc.accept(path);
- summary.deletedFile(path, type);
- });
+
+ withDefaultDeleteService(executorService, (deleteService) -> {
Review Comment:
This covers ExpireSnapshots and DropTable with Purge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
