Fokko commented on code in PR #6574:
URL: https://github.com/apache/iceberg/pull/6574#discussion_r1070259471
##########
python/pyiceberg/table/__init__.py:
##########
@@ -341,7 +346,18 @@ def plan_files(self) -> Iterator[FileScanTask]:
all_files = files(io.new_input(manifest.manifest_path))
matching_partition_files = filter(partition_filter, all_files)
- yield from (FileScanTask(file) for file in
matching_partition_files)
+ def _check_content(file: ManifestFile) -> ManifestFile:
+ try:
+ if file.content == ManifestContent.DELETES:
+ raise ValueError("PyIceberg does not support deletes:
https://github.com/apache/iceberg/issues/6568";)
Review Comment:
Good call, I ran some table scans locally, but great idea to have this
unit-tested as well 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
