Fokko commented on code in PR #6525:
URL: https://github.com/apache/iceberg/pull/6525#discussion_r1069166440
##########
python/tests/test_schema.py:
##########
@@ -386,13 +386,16 @@ def test_build_position_accessors(table_schema_nested:
Schema) -> None:
def test_build_position_accessors_with_struct(table_schema_nested: Schema) ->
None:
class TestStruct(StructProtocol):
+ def set_record_schema(self, record_schema: StructType) -> None:
Review Comment:
Nice, that's redundant indeed!
##########
python/tests/test_schema.py:
##########
@@ -386,13 +386,16 @@ def test_build_position_accessors(table_schema_nested:
Schema) -> None:
def test_build_position_accessors_with_struct(table_schema_nested: Schema) ->
None:
class TestStruct(StructProtocol):
+ def set_record_schema(self, record_schema: StructType) -> None:
Review Comment:
Nice, that's not required anymore!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
