dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1068815596
########## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeTableMetadata.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.snowflake; + +import com.fasterxml.jackson.databind.JsonNode; +import java.io.IOException; +import java.util.regex.Matcher; +import java.util.regex.Pattern; +import org.apache.iceberg.relocated.com.google.common.base.Objects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.util.JsonUtil; + +class SnowflakeTableMetadata { + public static final Pattern SNOWFLAKE_AZURE_PATTERN = + Pattern.compile("azure://([^/]+)/([^/]+)/(.*)"); + + private final String snowflakeMetadataLocation; + private final String icebergMetadataLocation; + private final String status; + + // Note: Since not all sources will necessarily come from a raw JSON representation, this raw + // JSON should only be considered a convenient debugging field. Equality of two + // SnowflakeTableMetadata instances should not depend on equality of this field. + private final String rawJsonVal; + + SnowflakeTableMetadata( + String snowflakeMetadataLocation, + String icebergMetadataLocation, + String status, + String rawJsonVal) { + this.snowflakeMetadataLocation = snowflakeMetadataLocation; + this.icebergMetadataLocation = icebergMetadataLocation; + this.status = status; + this.rawJsonVal = rawJsonVal; + } + + /** Storage location of table metadata in Snowflake's path syntax. */ + public String snowflakeMetadataLocation() { + return snowflakeMetadataLocation; + } + + /** Storage location of table metadata in Iceberg's path syntax. */ + public String icebergMetadataLocation() { + return icebergMetadataLocation; + } + + public String getStatus() { + return status; + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } else if (!(o instanceof SnowflakeTableMetadata)) { + return false; + } + + // Only consider parsed fields, not the raw JSON that may or may not be the original source of + // this instance. + SnowflakeTableMetadata that = (SnowflakeTableMetadata) o; + return Objects.equal(this.snowflakeMetadataLocation, that.snowflakeMetadataLocation) + && Objects.equal(this.icebergMetadataLocation, that.icebergMetadataLocation) + && Objects.equal(this.status, that.status); + } + + @Override + public int hashCode() { + return Objects.hashCode(snowflakeMetadataLocation, icebergMetadataLocation, status); + } + + @Override + public String toString() { + return String.format( + "snowflakeMetadataLocation: '%s', icebergMetadataLocation: '%s', status: '%s'", + snowflakeMetadataLocation, icebergMetadataLocation, status); + } + + public String toDebugString() { + return String.format("%s, rawJsonVal: %s", toString(), rawJsonVal); + } + + /** + * Translates from Snowflake's path syntax to Iceberg's path syntax for paths matching known + * non-compatible Snowflake paths. Throws IllegalArgumentException if the prefix of the + * snowflakeLocation is a known non-compatible path syntax but fails to match the expected path + * components for a successful translation. + */ + public static String snowflakeLocationToIcebergLocation(String snowflakeLocation) { Review Comment: Right, in situations where Snowflake handles paths coming from externally produced sources, Snowflake tracks a canonical form of it and indeed handles s3a and s3n. Here, the conversion is for outbound paths produced by Snowflake, where the "s3://" prefix is already used natively, so only Azure and GCS need translation for "standard" scheme mappings accepted by e.g. HadoopFileSystem. This does remind me though - I've been meaning to open a discussion to see if anyone has thought about maybe adding some ease-of-use hooks for last-mile automatic basic path translations right before they go to FileIO resolution. For example, someone might want `s3://somebucket` paths to be rewritten to a `viewfs://` base path before letting HadoopFileIO automatically delegate to the right ViewFs impl. Or it could come up in cases where manifest files hold `s3://` paths but someone wants everything to go through a corresponding `dbfs://` mount point. Do you know of any prior discussions along those lines, and would it be worth opening an issue for broader input? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
