rdblue commented on code in PR #6525:
URL: https://github.com/apache/iceberg/pull/6525#discussion_r1068814708
##########
python/pyiceberg/avro/reader.py:
##########
@@ -238,41 +248,51 @@ def skip(self, decoder: BinaryDecoder) -> None:
return self.option.skip(decoder)
-class StructProtocolReader(Reader):
- create_struct: Callable[[], StructProtocol]
- fields: Tuple[Tuple[Optional[int], Reader], ...]
+class StructReader(Reader):
+ field_readers: Tuple[Tuple[Optional[int], Reader], ...]
+ create_struct: Callable[[StructType], StructProtocol]
+ struct: StructType
- def __init__(self, fields: Tuple[Tuple[Optional[int], Reader], ...],
create_struct: Callable[[], StructProtocol]):
+ def __init__(
+ self,
+ field_readers: Tuple[Tuple[Optional[int], Reader], ...],
+ create_struct: Callable[[StructType], StructProtocol],
+ struct: StructType,
+ ) -> None:
+ self.field_readers = field_readers
self.create_struct = create_struct
- self.fields = fields
+ self.struct = struct
- def create_or_reuse(self, reuse: Optional[StructProtocol]) ->
StructProtocol:
- if reuse:
- return reuse
- else:
- return self.create_struct()
+ def read(self, decoder: BinaryDecoder) -> StructProtocol:
+ struct = self.create_struct(self.struct)
- def read(self, decoder: BinaryDecoder) -> Any:
- struct = self.create_or_reuse(None)
+ if not issubclass(struct.__class__, StructProtocol):
Review Comment:
I'm curious, why not use `isinstance`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
