[GitHub] [iceberg] jackye1995 commented on a diff in pull request #4479: Spark 3.2: support rate limit in Spark Streaming

[GitBox]

jackye1995 commented on code in PR #4479:
URL: https://github.com/apache/iceberg/pull/4479#discussion_r1068561664


##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -205,12 +205,16 @@ private List<FileScanTask> planFiles(StreamingOffset 
startOffset, StreamingOffse
         continue;
       }
 
+      Snapshot currentSnapshot = table.snapshot(currentOffset.snapshotId());

Review Comment:
   can we avoid changes to multiple Spark versions at this moment? I guess 
making a new method instead of changing the method parameters would help that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org