ConeyLiu commented on code in PR #6335:
URL: https://github.com/apache/iceberg/pull/6335#discussion_r1063976959
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -49,8 +51,9 @@ class FastAppend extends SnapshotProducer<AppendFiles>
implements AppendFiles {
private final List<DataFile> newFiles = Lists.newArrayList();
private final List<ManifestFile> appendManifests = Lists.newArrayList();
private final List<ManifestFile> rewrittenAppendManifests =
Lists.newArrayList();
- private ManifestFile newManifest = null;
+ private List<ManifestFile> cachedNewManifests = null;
Review Comment:
@RussellSpitzer Do you mean the `caching` part here? Here just rename the
variable because it is plural now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
