jackye1995 commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1063972214
########## delta-lake/src/main/java/org/apache/iceberg/delta/SupportMigrationFromDeltaLake.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.delta; + +/** + * An API that should be implemented by query engine integrations that want to support migration + * from Delta Lake table to Iceberg table. + */ +public interface SupportMigrationFromDeltaLake { + + /** Initiates an action to migrate an existing Delta Lake table to Iceberg. */ + default MigrateDeltaLakeTable migrateDeltaLakeTable(String tableIdent, String deltaS3Location) { Review Comment: One thing I notice is that, we should not call this `MigrateDeltaLakeTable`, this is actually `SnapshotDeltaLakeTTable` action, because we rename the table to a new name. This also resonates with my last comment about location. If we see the `SnapshotTable` interface, it has methods like `as` and `location` which are what you have in constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
