danielcweeks commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1063860728
########## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeIdentifier.java: ########## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.snowflake; + +import org.apache.iceberg.relocated.com.google.common.base.Objects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * Since the SnowflakeCatalog supports exactly two levels of Iceberg Namespaces, corresponding + * directly to the "database" and "schema" portions of Snowflake's resource model, this class + * represents a pre-validated and structured representation of a fully-qualified Snowflake resource + * identifier. Snowflake-specific helper libraries should operate on this representation instead of + * directly operating on TableIdentifiers or Namespaces wherever possible to avoid duplication of + * parsing/validation logic for Iceberg TableIdentifier/Namespace levels. + */ +class SnowflakeIdentifier { + public enum Type { + ROOT, + DATABASE, + SCHEMA, + TABLE + } + + private String databaseName; + private String schemaName; + private String tableName; + private Type type; Review Comment: These can all be final -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
