RussellSpitzer commented on code in PR #6524:
URL: https://github.com/apache/iceberg/pull/6524#discussion_r1062922626
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -106,41 +106,41 @@ public SparkScanBuilder caseSensitive(boolean
isCaseSensitive) {
@Override
public Filter[] pushFilters(Filter[] filters) {
List<Expression> expressions =
Lists.newArrayListWithExpectedSize(filters.length);
- List<Filter> pushed = Lists.newArrayListWithExpectedSize(filters.length);
+ List<Filter> pushableFilters =
Lists.newArrayListWithExpectedSize(filters.length);
+ List<Filter> postScanFilters =
Lists.newArrayListWithExpectedSize(filters.length);
Review Comment:
I think that's fine, I don't really like the Spark nomenclature here but I
think your comment does a good job defining it. I think I would add that. (1)
and (2) are placed in "PushableFilters" and (2) and (3) are returned to spark
in "postScanFilters"
Really I just think
IcebergPushedFilters and
SparkPostScanFilters would also be nice but I think your comment provides
enough context for a non-spark expert to get what's going on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
