szehon-ho commented on code in PR #6451: URL: https://github.com/apache/iceberg/pull/6451#discussion_r1061999067
########## hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreClientVersion.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.hive; + +import org.apache.hive.common.util.HiveVersionInfo; + +public enum MetastoreClientVersion { + HIVE_4(4), + HIVE_3(3), + HIVE_2(2), + HIVE_1_2(1), + NOT_SUPPORTED(0); + + private final int order; + private static final MetastoreClientVersion current = calculate(); + + MetastoreClientVersion(int order) { + this.order = order; + } + + public static MetastoreClientVersion current() { + return current; + } + + public static boolean min(MetastoreClientVersion other) { + return current.order >= other.order; + } + + private static MetastoreClientVersion calculate() { + String version = HiveVersionInfo.getShortVersion(); + String[] versions = version.split("\\."); + switch (versions[0]) { + case "4": + return HIVE_4; + case "3": + return HIVE_3; + case "2": + return HIVE_2; + case "1": + if (versions[1].equals("2")) { + return HIVE_1_2; + } else { + return NOT_SUPPORTED; Review Comment: Why are we explicitly not-supporting versions lesser than Hive 1.2 now? I don't think there was any checks previously to throw an exception for this case. Anyway, we are protecting the agentInfo code already with a Hive 2 check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
