rdblue commented on code in PR #6485: URL: https://github.com/apache/iceberg/pull/6485#discussion_r1059493412
########## api/src/main/java/org/apache/iceberg/encryption/KmsClient.java: ########## @@ -22,7 +22,8 @@ import java.nio.ByteBuffer; import java.util.Map; -/** A minimum client interface to connect to a key management service (KMS). */ +/** @deprecated A minimum client interface to connect to a key management service (KMS). */ Review Comment: This should also state when the API will be removed (in 2.0.0). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
