amogh-jahagirdar commented on code in PR #6501:
URL: https://github.com/apache/iceberg/pull/6501#discussion_r1058668353
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -230,6 +240,14 @@ def _get_fs(self, scheme: str) -> FileSystem:
else:
raise ValueError(f"Unrecognized filesystem type in URI: {scheme}")
+ def _get_file(self, location: str) -> PyArrowFile:
+ scheme, path = self.parse_location(location)
+ fs = self._get_fs(scheme)
+
+ buffer_size = self.properties.get(BUFFER_SIZE)
Review Comment:
Just a nit, I feel it's a bit more readable if we return the 1 MB default
buffer size here and then pass that through. Then buffer size is a required
integer for PyArrowFile and the constructor logic is simpler imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
