jackye1995 commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1058511168
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/MigrateDeltaLakeTableSparkAction.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.actions; + +import java.util.Map; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.delta.BaseMigrateDeltaLakeTableAction; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.spark.Spark3Util; +import org.apache.spark.sql.SparkSession; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Takes a Delta Lake table and attempts to transform it into an Iceberg table in the same location + * with the same identifier. Once complete the identifier which previously referred to a non-Iceberg + * table will refer to the newly migrated Iceberg table. + */ +public class MigrateDeltaLakeTableSparkAction extends BaseMigrateDeltaLakeTableAction { + + private static final Logger LOG = LoggerFactory.getLogger(MigrateDeltaLakeTableSparkAction.class); + + private final SparkSession spark; + + MigrateDeltaLakeTableSparkAction( + SparkSession spark, String deltaTableLocation, String newTableIdentifier) { + super( + Spark3Util.loadIcebergCatalog( + spark, spark.sessionState().catalogManager().currentCatalog().name()), + deltaTableLocation, + TableIdentifier.parse(newTableIdentifier), + spark.sessionState().newHadoopConf()); + this.spark = spark; + Map<String, String> properties = Maps.newHashMap(); + properties.putAll(ImmutableMap.of("provider", "iceberg")); Review Comment: this might not be needed, because it's usually already a part of the existing table properties for a Spark table, and we already do `properties.putAll(deltaSnapshot.getMetadata().getConfiguration());` when adding additional table properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
