rdblue commented on code in PR #6432: URL: https://github.com/apache/iceberg/pull/6432#discussion_r1055832837
########## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ########## @@ -135,6 +142,17 @@ public static StructLikeSet toEqualitySet( } } + static ExecutorService getDeletePosThreadPool() { + return (SystemProperties.getBoolean(SystemProperties.DELETE_POS_FILES_THREADS_ENABLED, false)) + ? ThreadPools.newWorkerPool(SystemProperties.DELETE_POS_FILES_THREADS_ENABLED) + : null; Review Comment: Should this be in ThreadPools like the worker pool? I think setting pool size there like we do for the worker pool makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org