dennishuo commented on code in PR #6428: URL: https://github.com/apache/iceberg/pull/6428#discussion_r1054082154
########## versions.props: ########## @@ -28,6 +28,8 @@ org.scala-lang.modules:scala-collection-compat_2.12 = 2.6.0 org.scala-lang.modules:scala-collection-compat_2.13 = 2.6.0 com.emc.ecs:object-client-bundle = 3.3.2 org.immutables:value = 2.9.2 +commons-dbutils:commons-dbutils = 1.7 Review Comment: Just QueryRunner with its statement-configuration/parameter-handling functionality along with the ResultSetHandler interface. Turned out to be surprisingly easy to replace the whole dbutils dependency with analogous but significantly simplified interfaces inline in JdbcSnowflakeClient.java, especially since we're only using String parameters in PreparedStatements for now and we probably don't need to worry about some of the more advanced dbutils configuration of things like maxFieldSize, fetchSize, etc. for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
