ajantha-bhat commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1053480162
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1211,6 +1211,7 @@ public Builder removeSnapshots(Collection<Long>
idsToRemove) {
if (idsToRemove.contains(snapshotId)) {
snapshotsById.remove(snapshotId);
changes.add(new MetadataUpdate.RemoveSnapshot(snapshotId));
+ removeStatistics(snapshotId);
Review Comment:
expire snapshots used to remove the expired snapshot entires from
`TableMetadata` (which is changing contents of `TableMetadata`).
So, now that those snapshots are expired. We need to clean up the statistics
files entires present for those expired snapshots. Hence, modifying the
`TableMetadata`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
