rdblue commented on code in PR #6460:
URL: https://github.com/apache/iceberg/pull/6460#discussion_r1053449241
##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -234,12 +225,14 @@ public long start() {
@Override
public long length() {
- return manifestListTask.length();
+ // return a generic length to avoid looking up the actual length
+ return 8192;
}
@Override
public Expression residual() {
- return manifestListTask.residual();
+ // this table is unpartitioned so the residual is always constant
+ return residual;
Review Comment:
I don't think this is used, but I would still make it the correct residual.
An unpartitioned table always has the same residual as the original filter, so
this is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
