nastra commented on code in PR #6399:
URL: https://github.com/apache/iceberg/pull/6399#discussion_r1049921925
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -396,7 +399,9 @@ public void commit() {
} catch (CommitStateUnknownException commitStateUnknownException) {
throw commitStateUnknownException;
} catch (RuntimeException e) {
- Exceptions.suppressAndThrow(e, this::cleanAll);
+ if (!strictCleanup || e instanceof CleanableFailure) {
+ Exceptions.suppressAndThrow(e, this::cleanAll);
Review Comment:
just curious, would we need check for `strictCleanup` in
https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/BaseTransaction.java#L453-L463
as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
