[GitHub] [iceberg] dmgcodevil commented on a diff in pull request #3337: Fixed issue #3336: Best efforts to release hive table lock

[GitBox]

dmgcodevil commented on code in PR #3337:
URL: https://github.com/apache/iceberg/pull/3337#discussion_r1048815939


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -499,11 +499,21 @@ private void unlock(Optional<Long> lockId) {
   }
 
   @VisibleForTesting
-  void doUnlock(long lockId) throws TException, InterruptedException {
-    metaClients.run(client -> {
-      client.unlock(lockId);
-      return null;
-    });
+  void doUnlock(long lockId) throws TException {
+    boolean released = false;
+    while (!released) {
+      try {
+        released = metaClients.run(client -> {

Review Comment:
   there is no retry. also:
   
   ```
   catch (RuntimeException e) {
           throw e;
         }
   ```
   
   is redundant 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org