hililiwei commented on code in PR #6402: URL: https://github.com/apache/iceberg/pull/6402#discussion_r1048054508
########## flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java: ########## @@ -603,7 +605,103 @@ public void testFilterPushDown2Literal() { } @Test - public void testSqlParseNaN() { - // todo add some test case to test NaN + public void testFilterNaN() { + sql( + "CREATE TABLE %s (id INT, data VARCHAR,d DOUBLE, f FLOAT) WITH ('write.format.default'='%s')", Review Comment: Delete the tests for FLOAT.NAN as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org