hililiwei commented on code in PR #6394:
URL: https://github.com/apache/iceberg/pull/6394#discussion_r1044997749
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -84,7 +84,7 @@ public IcebergTableSource(
TableSchema schema,
Map<String, String> properties,
ReadableConfig readableConfig) {
- this(loader, schema, properties, null, false, -1, ImmutableList.of(),
readableConfig);
+ this(loader, schema, properties, null, false, null, ImmutableList.of(),
readableConfig);
Review Comment:
The value here overrides flink config. It should set a default value `null`,
and then the read conf take the default value -1 when no one(options\config) is
used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
