flyrain commented on PR #6344: URL: https://github.com/apache/iceberg/pull/6344#issuecomment-1345156075
Thanks @szehon-ho @RussellSpitzer for the review. Resolve all comments. Particularly, I have removed the flag `markUpdated`. I tried to use the flag to cover more use cases like following: 1. Users want to remove carry-over rows without generating the update rows. 2. Users want to remove carry-over rows and generate the update rows. I think it may make more sense to have different iterators. The PR is only for the case 2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
