nastra commented on code in PR #6246:
URL: https://github.com/apache/iceberg/pull/6246#discussion_r1044992928
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -71,9 +73,19 @@ enum TransactionType {
private TableMetadata base;
private TableMetadata current;
private boolean hasLastOpCommitted;
+ private final MetricsReporter reporter;
BaseTransaction(
String tableName, TableOperations ops, TransactionType type,
TableMetadata start) {
+ this(tableName, ops, type, start, LoggingMetricsReporter.instance());
+ }
+
+ BaseTransaction(
Review Comment:
the old constructor is still being used at a few places, so we either adjust
those places to always pass a `LoggingMetricsReporter.instance()` or we leave
the old constructor and pass `LoggingMetricsReporter.instance()` from there. I
chose the latter approach as it requires less changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
