rdblue commented on code in PR #6342:
URL: https://github.com/apache/iceberg/pull/6342#discussion_r1044924166
##########
python/pyiceberg/schema.py:
##########
@@ -317,6 +331,97 @@ def primitive(self, primitive: PrimitiveType) -> T:
"""Visit a PrimitiveType"""
+class SchemaVisitorPerPrimitiveType(SchemaVisitor[T], ABC):
+ def primitive(self, primitive: PrimitiveType) -> T:
+ """Visit a PrimitiveType"""
+ if isinstance(primitive, FixedType):
Review Comment:
Are repeated `isinstance` checks going to introduce overhead compared to
using `@singledistpatchmethod` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
