rdblue commented on code in PR #6246:
URL: https://github.com/apache/iceberg/pull/6246#discussion_r1044918769
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -112,6 +122,19 @@ public ThisT scanManifestsWith(ExecutorService
executorService) {
return self();
}
+ protected SnapshotMetrics snapshotMetrics() {
Review Comment:
I wonder if this should be `commitMetrics` instead of being specific to a
snapshot producer. We certainly care the most about commits that write
snapshots, but we may want to at least time and track attempts for other
commits as well. This could be done later, but we probably want to get the
naming right right away.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
