cccs-eric commented on code in PR #6392:
URL: https://github.com/apache/iceberg/pull/6392#discussion_r1043971934
##########
python/tests/conftest.py:
##########
@@ -76,13 +76,30 @@
def pytest_addoption(parser: pytest.Parser) -> None:
+ # S3 options
parser.addoption(
"--s3.endpoint", action="store", default="http://localhost:9000";,
help="The S3 endpoint URL for tests marked as s3"
)
parser.addoption("--s3.access-key-id", action="store", default="admin",
help="The AWS access key ID for tests marked as s3")
parser.addoption(
"--s3.secret-access-key", action="store", default="password",
help="The AWS secret access key ID for tests marked as s3"
)
+ # ADLFS options
+ parser.addoption(
+ "--adlfs.endpoint",
+ action="store",
+ default="http://127.0.0.1:10000";,
+ help="The ADLS endpoint URL for tests marked as adlfs",
+ )
+ parser.addoption(
+ "--adlfs.account-name", action="store", default="devstoreaccount1",
help="The ADLS account key for tests marked as adlfs"
Review Comment:
That account name is the one by default with azurite.
##########
python/tests/conftest.py:
##########
@@ -76,13 +76,30 @@
def pytest_addoption(parser: pytest.Parser) -> None:
+ # S3 options
parser.addoption(
"--s3.endpoint", action="store", default="http://localhost:9000";,
help="The S3 endpoint URL for tests marked as s3"
)
parser.addoption("--s3.access-key-id", action="store", default="admin",
help="The AWS access key ID for tests marked as s3")
parser.addoption(
"--s3.secret-access-key", action="store", default="password",
help="The AWS secret access key ID for tests marked as s3"
)
+ # ADLFS options
+ parser.addoption(
+ "--adlfs.endpoint",
+ action="store",
+ default="http://127.0.0.1:10000";,
+ help="The ADLS endpoint URL for tests marked as adlfs",
+ )
+ parser.addoption(
+ "--adlfs.account-name", action="store", default="devstoreaccount1",
help="The ADLS account key for tests marked as adlfs"
+ )
+ parser.addoption(
+ "--adlfs.account-key",
+ action="store",
+
default="Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==",
Review Comment:
That account key is the one by default with azurite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
