pavibhai commented on code in PR #6293:
URL: https://github.com/apache/iceberg/pull/6293#discussion_r1042041584


##########
orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java:
##########
@@ -88,8 +86,7 @@
       options.fileSystem(((HadoopOutputFile) file).getFileSystem());
     }
     options.setSchema(orcSchema);
-    this.writer = newOrcWriter(file, options, metadata);
-
+    this.writer = ORC.newFileWriter(file, options, metadata);

Review Comment:
   Yes that is still needed. We continue to retain the current behavior for 
HadoopIO. So the FileSystem from HadoopOutputFile or HadoopInputFile is used 
for the FS operations. When we use anything other than HadoopIO the FileIOFS 
kicks in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to