nastra commented on code in PR #6353:
URL: https://github.com/apache/iceberg/pull/6353#discussion_r1041833505
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetReader.java:
##########
@@ -79,9 +83,11 @@ private ReadConf<T> init() {
nameMapping,
reuseContainers,
caseSensitive,
- null);
- this.conf = readConf.copy();
- return readConf;
+ null)) {
+ this.conf = readConf.copy();
+ } catch (IOException e) {
+ LOG.warn("Failed to close ReadConf", e);
Review Comment:
I think it would make more sense to catch+log this inside `ReadConf.close()`
so that `ReadConf.close()` doesn't throw anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
