rdblue commented on code in PR #6346:
URL: https://github.com/apache/iceberg/pull/6346#discussion_r1038385171
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -409,22 +418,22 @@ def visit_not_null(self, term: BoundTerm[Any]) ->
pc.Expression:
return pc.field(term.ref().field.name).is_valid()
def visit_equal(self, term: BoundTerm[Any], literal: Literal[Any]) ->
pc.Expression:
- return pc.field(term.ref().field.name) == literal.value
+ return pc.field(term.ref().field.name) ==
_convert_scalar(literal.value, term.ref().field.field_type)
Review Comment:
How does this know what timestamp format our filter is in? Does it assume
micros?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
