[GitHub] [iceberg] pvary commented on a diff in pull request #6305: API: Override `equals` and `hashCode` methods for primitive types

[GitBox]

pvary commented on code in PR #6305:
URL: https://github.com/apache/iceberg/pull/6305#discussion_r1037861696


##########
api/src/main/java/org/apache/iceberg/types/Type.java:
##########
@@ -112,6 +113,23 @@ public PrimitiveType asPrimitiveType() {
     Object writeReplace() throws ObjectStreamException {
       return new PrimitiveHolder(toString());
     }
+
+    @Override
+    public boolean equals(Object o) {
+      if (this == o) {
+        return true;
+      } else if (!(o instanceof PrimitiveType)) {
+        return false;
+      }
+
+      PrimitiveType that = (PrimitiveType) o;
+      return typeId() == that.typeId();

Review Comment:
   What about `PrimitiveType` where we have an attribute?
   Like:
   - `TimestampType(boolean adjustToUTC)`
   - `FixedType ofLength(int length)`
   - `DecimalType of(int precision, int scale)`
   
   Do we consider them equals if the parameters are different?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org