stevenzwu commented on PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#issuecomment-1333082832
> Hmm, I understand your concern now. The job-level configuration should
have a connector prefix that makes sense to me, shall we consider using the
same prefix?
Yeah. I was worry about config naming collision. A common prefix like
`connector.iceberg.` should be enough. But it will be a problem to change it
for the write configs, which is already released.
> As for some configs that may target a specific table, how about adding the
table identifier in the config? The pattern would be
prefix.{identifier}.${table_config}.
I don't think we should add a table identifier for the Flink job config,
which should be common configs that applied to all Iceberg sources or sinks.
For table specific config, they should stay as SQL hint options or passed in
via the source/sink builder directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
