nastra commented on code in PR #6322:
URL: https://github.com/apache/iceberg/pull/6322#discussion_r1036235837
##########
api/src/test/java/org/apache/iceberg/io/TestCloseableIterable.java:
##########
@@ -201,6 +201,14 @@ public CloseableIterator<Integer> iterator() {
Assertions.assertThat(counter.get()).isEqualTo(items.size());
}
+ @Test
+ public void concatIterablesWithIterator() throws IOException {
Review Comment:
I specifically avoid naming it like this, because the important piece where
this NPE is happening is the usage of `.iterator()` before doing a `.close()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
