aokolnychyi commented on code in PR #6309: URL: https://github.com/apache/iceberg/pull/6309#discussion_r1035234966
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java: ########## @@ -63,7 +64,7 @@ class SparkBatchQueryScan extends SparkScan implements SupportsRuntimeFiltering private static final Logger LOG = LoggerFactory.getLogger(SparkBatchQueryScan.class); - private final TableScan scan; + private final Scan<?, ?, ?> scan; Review Comment: We could do something like this (if it is any better): ``` private final Scan<?, ? extends ScanTask, ?> scan private final Scan<?, ? extends ScanTask, ? extends ScanTaskGroup<?>> scan ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
