islamismailov commented on code in PR #6268:
URL: https://github.com/apache/iceberg/pull/6268#discussion_r1035135510
##########
core/src/test/java/org/apache/iceberg/TestPartitionSpecInfo.java:
##########
@@ -85,6 +85,31 @@ public void testSpecInfoPartitionedTable() {
Assert.assertNull(table.specs().get(Integer.MAX_VALUE));
}
+ @Test
+ public void testColumnDropWithPartitionSpecEvolution() {
+ PartitionSpec spec =
PartitionSpec.builderFor(schema).identity("id").build();
+ TestTables.TestTable table = TestTables.create(tableDir, "test", schema,
spec, formatVersion);
+
+ Assert.assertEquals(spec, table.spec());
+
+ TableMetadata base = TestTables.readMetadata("test");
+ PartitionSpec newSpec =
+
PartitionSpec.builderFor(table.schema()).identity("data").withSpecId(1).build();
+ table.ops().commit(base, base.updatePartitionSpec(newSpec));
+
+ int initialColSize = table.schema().columns().size();
+ table.updateSchema().deleteColumn("id").commit();
+
+ Assert.assertEquals(newSpec, table.spec());
+ Assert.assertEquals(newSpec, table.specs().get(newSpec.specId()));
+ Assert.assertEquals(spec, table.specs().get(spec.specId()));
+ Assert.assertEquals(
+ ImmutableMap.of(spec.specId(), spec, newSpec.specId(), newSpec),
table.specs());
+ Assert.assertNull(table.specs().get(Integer.MAX_VALUE));
+ Assert.assertEquals(
+ "Schema must have one less column", initialColSize - 1,
table.schema().columns().size());
Review Comment:
will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
