rdblue commented on code in PR #6259:
URL: https://github.com/apache/iceberg/pull/6259#discussion_r1034008760
##########
python/pyiceberg/expressions/literals.py:
##########
@@ -86,6 +86,8 @@ def __hash__(self) -> int:
return hash(self.value)
def __eq__(self, other: Any) -> bool:
+ if not isinstance(other, Literal):
Review Comment:
I don't think that we want to do that. Then equality would not be symmetric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
