RussellSpitzer commented on code in PR #6296:
URL: https://github.com/apache/iceberg/pull/6296#discussion_r1033767880


##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -356,6 +356,16 @@ public void testRewriteDataFilesWithInvalidInputs() {
                     + "sort_order => 'c1 ASC NULLS FIRST')",
                 catalogName, tableIdent));
 
+    // Test for sort strategy without any (default/user defined) sort_order
+    AssertHelpers.assertThrows(
+        "Should reject calls with error message",
+        IllegalArgumentException.class,
+        "Can't use SORT when there is no sort order",

Review Comment:
   "when the table has no defined sort order and the user has not set a 
specific sort order"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to