rdblue commented on code in PR #6258:
URL: https://github.com/apache/iceberg/pull/6258#discussion_r1032838052
##########
python/tests/io/test_pyarrow.py:
##########
@@ -411,3 +434,140 @@ def test_list_type_to_pyarrow():
element_required=True,
)
assert visit(iceberg_map, _ConvertToArrowSchema()) == pa.list_(pa.int32())
+
+
[email protected]
+def bound_reference(table_schema_simple: Schema) -> BoundReference[str]:
+ return BoundReference(table_schema_simple.find_field(1),
table_schema_simple.accessor_for_field(1))
+
+
[email protected]
+def bound_double_reference(table_schema_simple: Schema) ->
BoundReference[float]:
Review Comment:
Does this need `table_schema_simple`?
##########
python/tests/io/test_pyarrow.py:
##########
@@ -411,3 +434,140 @@ def test_list_type_to_pyarrow():
element_required=True,
)
assert visit(iceberg_map, _ConvertToArrowSchema()) == pa.list_(pa.int32())
+
+
[email protected]
+def bound_reference(table_schema_simple: Schema) -> BoundReference[str]:
+ return BoundReference(table_schema_simple.find_field(1),
table_schema_simple.accessor_for_field(1))
+
+
[email protected]
+def bound_double_reference(table_schema_simple: Schema) ->
BoundReference[float]:
+ schema = Schema(
+ NestedField(field_id=1, name="foo", field_type=DoubleType(),
required=False),
+ schema_id=1,
+ identifier_field_ids=[2],
+ )
Review Comment:
Should we have a fixture that has a double field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
