ajantha-bhat commented on PR #6240: URL: https://github.com/apache/iceberg/pull/6240#issuecomment-1323253673
@nastra: Review from Iceberg side is easy. But I would like to know, can Trino really use it? Looks to me that `client#commitTable` needs the below parameters. ``` commitTable( TableMetadata base, TableMetadata metadata, String newMetadataLocation, IcebergTable expectedContent, ContentKey expectedContent) ``` But the Trino interface (`NessieIcebergTableOperations#commitNewTable`) currently doesn't have `base`, `expectedContent` and these interfaces are common for other catalogs too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org