Fokko commented on issue #6204:
URL: https://github.com/apache/iceberg/issues/6204#issuecomment-1318656478

   @islamismailov I'm just seeing your gist. I think it looks good, except one 
copy-paste:
   ```
   +      if (defaultSortOrderId == null) {
   +        throw new IllegalArgumentException("Default sort order ID unset");
   +      }
   +
   +      if (defaultSortOrderId == 0) { // This should be 0 instead of null
   +        throw new IllegalArgumentException("Default sort order ID 0 is 
reserved for unsorted order");
   +      }
   +
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to