Fokko commented on code in PR #6159:
URL: https://github.com/apache/iceberg/pull/6159#discussion_r1020961137
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -120,16 +120,16 @@ def load_catalog(name: str, **properties: Optional[str])
-> Catalog:
or if it could not determine the catalog based on the properties
"""
env = _ENV_CONFIG.get_catalog_config(name)
- conf = merge_config(env or {}, properties)
+ conf = merge_config(env or {}, properties) # type: ignore
Review Comment:
@LuigiCerone I noticed that you ignored the type-check here. Anything that
we can do to make this pass instead of suppressing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
