[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #2276: Core: Add a util method to combine tasks by partition

[GitBox]

aokolnychyi commented on code in PR #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r1019833535


##########
api/src/main/java/org/apache/iceberg/util/StructProjection.java:
##########
@@ -171,6 +178,11 @@ public StructProjection wrap(StructLike newStruct) {
     return this;
   }
 
+  public StructProjection copyFor(StructLike newStruct) {
+    return new StructProjection(this.type, this.positionMap, 
this.nestedProjections)

Review Comment:
   nit: We usually use explicit `this.` only when setting values.
   I think it would fit on one line if we drop `this.` from these three 
variables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org