RussellSpitzer commented on code in PR #6163:
URL: https://github.com/apache/iceberg/pull/6163#discussion_r1019584432
##########
core/src/test/java/org/apache/iceberg/TestPartitioning.java:
##########
@@ -43,6 +43,12 @@ public class TestPartitioning {
required(1, "id", Types.IntegerType.get()),
required(2, "data", Types.StringType.get()),
required(3, "category", Types.StringType.get()));
+ private static final PartitionSpec BY_DATA_SPEC =
+ PartitionSpec.builderFor(SCHEMA).identity("data").build();
+ private static final PartitionSpec BY_CATEGORY_DATA_SPEC =
+
PartitionSpec.builderFor(SCHEMA).identity("category").identity("data").build();
+ private static final PartitionSpec BY_DATA_CATEGORY_BUCKET_SPEC =
+ PartitionSpec.builderFor(SCHEMA).identity("data").bucket("category",
8).build();
Review Comment:
Tests all look good to me, I think you covered all the cases we were
discussing yesterday. One nit is that we could probably parameterize this test
suite on format version, it looks like we expect the same output and run the
same code so we could shorten this file a bit with the parameterization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
