rdblue commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1018464014
##########
.palantir/revapi.yml:
##########
@@ -11,15 +92,21 @@ acceptedBreaks:
- code: "java.method.addedToInterface"
new: "method java.lang.String
org.apache.iceberg.expressions.Reference<T>::name()"
justification: "All subclasses implement name"
- - code: "java.method.addedToInterface"
- new: "method org.apache.iceberg.actions.MigrateTable
org.apache.iceberg.actions.MigrateTable::dropBackup()"
- justification: "Adding new functionality to allow for dropping backup
table"
- code: "java.method.addedToInterface"
new: "method java.util.List<org.apache.iceberg.StatisticsFile>
org.apache.iceberg.Table::statisticsFiles()"
justification: "new API method"
+ - code: "java.method.addedToInterface"
+ new: "method org.apache.iceberg.TableScan
org.apache.iceberg.TableScan::useRef(java.lang.String)"
+ justification: "Adding table scan APIs to support scanning from refs"
+ - code: "java.method.addedToInterface"
+ new: "method org.apache.iceberg.actions.MigrateTable
org.apache.iceberg.actions.MigrateTable::dropBackup()"
+ justification: "Adding new functionality to allow for dropping backup
table"
Review Comment:
Same here, we should add a default implementation that throws an exception
to avoid needing to suppress this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
