haizhou-zhao commented on PR #6045: URL: https://github.com/apache/iceberg/pull/6045#issuecomment-1309388616
Hey Gabor, Thanks for your last round of review. All your comments make sense to me and taken. Major changes in the latest commit: 1. createNamespace, setProp, removeProp each check input parameters separately 2. createNamespace allows users to create with both owner & owner-type specified or with only owner specified (in which case default owner-type to "user") 3. setProp requires users to specify owner & owner-type at the same time or not at all (in which case, there's no ownership change) 4. removeProp requires users to specify owner & owner-type at the same time (in which case, ownership is reset to default) or not at all (in which case, ownership is not changed) 5. unit test modified accordingly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
