Fokko commented on code in PR #6131: URL: https://github.com/apache/iceberg/pull/6131#discussion_r1016261138
########## python/pyiceberg/table/__init__.py: ########## @@ -14,30 +14,43 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. - - -from typing import Dict, List, Optional - -from pydantic import Field - +from typing import ( + ClassVar, + Dict, + List, + Optional, +) + +from pyiceberg.expressions import AlwaysTrue, And, BooleanExpression from pyiceberg.schema import Schema from pyiceberg.table.metadata import TableMetadata from pyiceberg.table.partitioning import PartitionSpec from pyiceberg.table.snapshots import Snapshot, SnapshotLogEntry from pyiceberg.table.sorting import SortOrder -from pyiceberg.typedef import Identifier -from pyiceberg.utils.iceberg_base_model import IcebergBaseModel +from pyiceberg.typedef import EMPTY_DICT, Identifier, Properties + +class Table: Review Comment: The schema method was already there before this PR, why is removing it now? 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
